Using java-libkiwix 2.2.4 to fix native crashes happens while getting the getEntryByPath, and getData() methods.
#4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the `getEntryByPath`, and `getData()` methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4190 +/- ##
============================================
+ Coverage 56.77% 56.80% +0.02%
+ Complexity 1537 1534 -3
============================================
Files 313 313
Lines 13510 13510
Branches 1695 1695
============================================
+ Hits 7670 7674 +4
+ Misses 4674 4673 -1
+ Partials 1166 1163 -3 ☔ View full report in Codecov by Sentry. |
|
@kelson42 This PR is ready for review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3956
We have fixed this issue on
java-libkiwixside see kiwix/java-libkiwix#116 for full details.