Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix Desktop should be called "Kiwix" for end-users #1302

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kelson42
Copy link
Collaborator

Part of #1243

@kelson42 kelson42 force-pushed the binary-called-kiwix branch from f014f8e to 40d0632 Compare December 24, 2024 09:28
@kelson42 kelson42 changed the title Rename binary from kiwix-desktop to kiwix Kiwix Desktop should be called "Kiwix" for end-users Dec 24, 2024
@kelson42 kelson42 mentioned this pull request Dec 26, 2024
@kelson42 kelson42 force-pushed the binary-called-kiwix branch from 812243a to 9f3bd13 Compare December 26, 2024 21:39
@kelson42 kelson42 force-pushed the binary-called-kiwix branch from 9eef5e9 to 0b83943 Compare January 5, 2025 01:29
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require respective changes in kiwix-build. I think that a draft version of that PR should be prepared before we merge this one.

@@ -6,7 +6,7 @@
"name":"English",
"error-title":"Error",
"error-downloader-window-title":"Cannot create downloader",
"error-downloader-launch-message":"Impossible to launch downloader, Kiwix-desktop will start but all download functions will not working!",
"error-downloader-launch-message":"Impossible to launch downloader, Kiwix will start but all download functions will not working!",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the grammar in this message. It should rather read

"Impossible to launch the downloader, Kiwix will start but download functionality will not work!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants