Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bookmarks between books #1043

Merged
merged 18 commits into from
Feb 15, 2024

Add a small test on getBestTargetBookId and flavour.

6b05eeb
Select commit
Loading
Failed to load commit list.
Merged

Migrate bookmarks between books #1043

Add a small test on getBestTargetBookId and flavour.
6b05eeb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 15, 2024 in 0s

41.03% (+1.66%) compared to c768d05

View this Pull Request on Codecov

41.03% (+1.66%) compared to c768d05

Details

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (c768d05) 39.36% compared to head (6b05eeb) 41.03%.

Files Patch % Lines
src/library.cpp 52.33% 3 Missing and 48 partials ⚠️
src/libxml_dumper.cpp 0.00% 0 Missing and 5 partials ⚠️
src/bookmark.cpp 70.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   39.36%   41.03%   +1.66%     
==========================================
  Files          58       58              
  Lines        4075     4187     +112     
  Branches     2245     2303      +58     
==========================================
+ Hits         1604     1718     +114     
+ Misses       1091     1003      -88     
- Partials     1380     1466      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.