Translation of search results page #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 39.35% 39.36%
=======================================
Files 58 58
Lines 4060 4075 +15
Branches 2236 2245 +9
=======================================
+ Hits 1598 1604 +6
Misses 1091 1091
- Partials 1371 1380 +9 ☔ View full report in Codecov by Sentry. |
|
@veloman-yunkan I guess its time to rebase this PR. |
However it is NOT actually translated by the backend yet
However it is NOT actually translated by the backend yet
However it is NOT actually translated by the backend yet
Now the search results page is presented by the backend in the language controlled by the value of the `userlang` URL query parameter (or, if the latter is missing, the value of the `Accept-Language:` HTTP header). Note that the front-end doesn't yet take advantage of this functionality.
veloman-yunkan
force-pushed
the
translation_of_search_results_page
branch
from
1cde0dd to
34cd553
Compare
@kelson42 You are right. I could sense the same recommendation in my horoscope for today and humbly complied with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028
Contrary to #1032 (comment), no front-end side translation is performed on the search results page. Instead the
/searchendpoint is called with theuserlangquery parameter explicitly provided. The downside is the reduced opportunity for HTTP-caching search requests coming from users using different UI languages.Currently no real translations of messages related to search results are available. To test this change you will have to use the
testlanguage that is excluded from the UI language selector. It can be set by adding (once)?userlang=testafter/viewerin the browser address bar.Known issues: