Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mark accounts created in a tx as created #789

Merged
merged 2 commits into from
Apr 24, 2024
Merged

feat: mark accounts created in a tx as created #789

merged 2 commits into from
Apr 24, 2024

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Apr 23, 2024 •
edited by enitrat
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #788

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

enitrat
enitrat requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit tests

enitrat
enitrat approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, lgtm

@enitrat enitrat merged commit af1a8db into kkrt-labs:main Apr 24, 2024
2 of 3 checks passed
@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 24, 2024

@enitrat do you want me to add unit tests in addition? I can do that

@enitrat
Copy link
Contributor

enitrat commented Apr 24, 2024

no, it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: mark accounts created in a transaction as "created"
2 participants
@TAdev0 @enitrat