Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rip-7212 implementation incorrect return value #790

Merged
merged 2 commits into from
May 6, 2024

Conversation

ulerdogan
Copy link
Contributor

@ulerdogan ulerdogan commented Apr 26, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The current implementation doesn't meet with actual RIP-7212 behavior for the return values. It returns unwanted 0 value for some cases.

Resolves: #

What is the new behavior?

The changes apply true behavior for the RIP-7212.

- **Output data:**
    - If the signature verification process succeeds, it returns 1 in 32 bytes format.
    - If the signature verification process fails, it does not return any output data.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

enitrat
enitrat previously approved these changes Apr 26, 2024
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ❤️

@enitrat enitrat added this pull request to the merge queue May 6, 2024
Merged via the queue into kkrt-labs:main with commit d7ea4af May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants