Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: const fixed size arrays #822

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Feat: const fixed size arrays #822

merged 2 commits into from
Aug 8, 2024

Conversation

remybar
Copy link
Contributor

@remybar remybar commented Aug 8, 2024 •
edited by enitrat
Loading

See issue #806.

The first commit uses const fixed-size arrays in the code while the second one uses const fixed-size arrays in tests.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@remybar remybar force-pushed the feat-const_fixed_size_arrays branch 3 times, most recently from d87ee97 to 11881cf Compare August 8, 2024 12:22
@remybar remybar changed the title Feat const fixed size arrays Feat: const fixed size arrays Aug 8, 2024
@remybar remybar marked this pull request as ready for review August 8, 2024 12:37
enitrat
enitrat reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also adapt pow2 and pow256_rev ?

crates/contracts/src/account_contract.cairo Outdated Show resolved Hide resolved
crates/evm/src/instructions/environmental_information.cairo Outdated Show resolved Hide resolved
@remybar remybar force-pushed the feat-const_fixed_size_arrays branch from 11881cf to 4752a88 Compare August 8, 2024 14:39
@remybar
Copy link
Contributor Author

remybar commented Aug 8, 2024

can you also adapt pow2 and pow256_rev ?

Yes, done 👍

@enitrat enitrat added this pull request to the merge queue Aug 8, 2024
Merged via the queue into kkrt-labs:main with commit 5a0f044 Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remybar @enitrat