Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

feat: TLOAD and TSTORE #873

Merged
merged 4 commits into from
Aug 28, 2024
Merged

feat: TLOAD and TSTORE #873

merged 4 commits into from
Aug 28, 2024

Conversation

obatirou
Copy link
Contributor

@obatirou obatirou commented Aug 27, 2024 •
edited by enitrat
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #846
Resolves: #847

What is the new behavior?

TLOAD and TSTORE are implemented

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

obatirou
obatirou commented Aug 27, 2024
View reviewed changes
enitrat
enitrat reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add exec_tstore and exec_tload in the intrepreter big if/else table that jumps based on the opcode number to the correct function

@enitrat enitrat enabled auto-merge August 28, 2024 07:54
@enitrat enitrat added this pull request to the merge queue Aug 28, 2024
Merged via the queue into kkrt-labs:main with commit 90878e2 Aug 28, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement TLOAD feat: implement TSTORE
2 participants
@obatirou @enitrat