Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: differentiate reverts from run exceptions #902

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: differentiate reverts from run exceptions #902

merged 4 commits into from
Sep 4, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 4, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #897

What is the new behavior?

  • Introduces a new enum (success, revert, exception) to differentiate between execution statuses
  • Exceptions are supposed to clear the returndata buffer and not reimburse gas left - unlike reverts

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat merged commit 9912d60 into main Sep 4, 2024
4 checks passed
@enitrat enitrat deleted the feat/handle-run-exceptions branch September 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: differentiate betwteen REVERT opcodes an exceptional failures
1 participant
@enitrat