Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory expansions #913

Merged
merged 5 commits into from
Sep 6, 2024
Merged

fix: memory expansions #913

merged 5 commits into from
Sep 6, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 6, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #910
Resolves: #911

What is the new behavior?

  • Fixes a bug where memory expansion was not always applied properly, as the max memory offset written could be different from the max theoritical memory offset passed in calls.
  • As memory is always resized prior to calls / operations, removed length checks & expansions in the memory trait
  • Fixes a bug where memory expansion was computed based on the max offset, even if the associated size written was zero.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat changed the title fix: memory expansion timing fix: memory expansions Sep 6, 2024
@enitrat enitrat merged commit 7cbfdae into main Sep 6, 2024
4 checks passed
@enitrat enitrat deleted the fix/memory-expansion branch September 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant