Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eth transaction model #922

Merged
merged 6 commits into from
Sep 11, 2024
Merged

refactor: eth transaction model #922

merged 6 commits into from
Sep 11, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 10, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #919

What is the new behavior?

  • Gas related variables are now u64
  • Refactored and cleaned the Transaction model: TxType, Transaction Enum, specific TX formats, etc - inspired by Reth
  • Prepares future easier verification of generic tx's, abstracting the type, for EIP1559

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat marked this pull request as ready for review September 11, 2024 08:39
@enitrat enitrat merged commit c66fe80 into main Sep 11, 2024
4 checks passed
@enitrat enitrat deleted the refactor/eth-transaction-model branch September 11, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou left review comments

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: refactor transaction model
2 participants
@enitrat @obatirou