Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use execute_from_outside #927

Merged
merged 7 commits into from
Sep 12, 2024
Merged

feat: use execute_from_outside #927

merged 7 commits into from
Sep 12, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 11, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #926 #908

What is the new behavior?

  • Defaults to using execute_from_oustide when executing transactions from EOA
  • Requires a relayer to invoke the execute_from_outside function, as the __execute__ and __validate__ entrypoints have been disabled

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat force-pushed the feat/use-execute-from-outside branch from 8f17f3e to 25699d2 Compare September 11, 2024 14:37
@enitrat enitrat force-pushed the feat/use-execute-from-outside branch from 25699d2 to abcdba6 Compare September 11, 2024 14:38
@enitrat enitrat marked this pull request as ready for review September 12, 2024 09:24
obatirou
obatirou previously approved these changes Sep 12, 2024
crates/contracts/src/account_contract.cairo Outdated Show resolved Hide resolved
crates/contracts/src/account_contract.cairo Show resolved Hide resolved
obatirou
obatirou previously approved these changes Sep 12, 2024
@enitrat enitrat force-pushed the feat/use-execute-from-outside branch from ef27e4f to fc726cc Compare September 12, 2024 12:09
@enitrat enitrat merged commit eeac8bb into main Sep 12, 2024
4 checks passed
@enitrat enitrat deleted the feat/use-execute-from-outside branch September 12, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: enable usage of execute_from_outside
2 participants