Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mcopy opcode #939

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: mcopy opcode #939

merged 3 commits into from
Sep 13, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 13, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes the order of arguments of the stack for the MCOPY opcode
  • Charge gas proportional to the amount of words copied

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat merged commit b1f7f8c into main Sep 13, 2024
3 checks passed
@enitrat enitrat deleted the fix/mcopy branch September 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enitrat