Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined variable #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined variable #60

wants to merge 1 commit into from

Conversation

sairoutine
Copy link

themes is not defined in getRandomTheme function.
Therefore, if keys.length is 0, an uncaught error would be occur.

@sairoutine
Copy link
Author

sairoutine commented Jun 30, 2022 •
edited
Loading

@klaussinani
Hi! It seems that travis-ci has some troubles and does not work.
Could you have any ideas to fix it?

@klaudiosinani klaudiosinani self-requested a review July 1, 2022 20:34
@klaudiosinani
Copy link
Owner

@sairoutine Thank you for taking the time to contribute! I will have a look into the CI and review the PR asap

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaudiosinani klaudiosinani Awaiting requested review from klaudiosinani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sairoutine @klaudiosinani