Exposing kv pairs properties #219
Conversation
| * Determine if the message is bearing key-value pairs | ||
| */ | ||
| val RemoteMessage.hasKlaviyoKeyValuePairs: Boolean | ||
| get() = this.isKlaviyoMessage && (this.data[KlaviyoNotification.KEY_VALUE_PAIRS_KEY]?.let { true } ?: false) |
There was a problem hiding this comment.
this.data.containsKey(KlaviyoNotification.KEY_VALUE_PAIRS_KEY) probs cleaner.
There was a problem hiding this comment.
Wouldn't I have to wrap everything in an if/else then too? (the let statement no longer works)
There was a problem hiding this comment.
don't need the let i mean, it should just return a bool of whether that key is present
There was a problem hiding this comment.
same as val RemoteMessage.isKlaviyoMessage: Boolean get() = this.data.containsKey("_k") elsewhere in this file
There was a problem hiding this comment.
Oo oops I was looking at the wrong method* (RemoteMessage.keyValuePairs) this makes more sense
| /** | ||
| * Parse out the key-value pairs into a string:string map | ||
| */ | ||
| val RemoteMessage.keyValuePairs: Map<String,String>? |
There was a problem hiding this comment.
Looks like we have a gap in our test coverage, this file has no corresponding test file. Would you mind adding a file in the same dir as KlaviyoPushServiceTest to cover your changes, and we'll backfill tests for other stuff in the future.
Description
Added two new extension properties to
RemoteMessages:hasKlaviyoKeyValuePairswhich is a boolean (trueif message payloads contain kv-pairs,falseotherwise)keyValuePairsoptionalMap<String,String>which is the dictionary of kv-pairs itself (deserialized from json)Check List
No.
How can I do this?
Changelog / Code Overview
Test Plan
onSilentPushMessageReceivedmethod)Related Issues/Tickets