Added constants exported from android. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started breaking more things out into files
|
I dunno what our CI is doing. Maybe lets just force merge this and follow up to fix CI. |
evan-masseau
commented
Dec 21, 2023
example/src/App.tsx
Outdated
| EventProperty, | ||
| EventType, | ||
| } from 'klaviyo-react-native-sdk'; | ||
| import { multiply } from '../../src/KlaviyoReactNativeSdk'; |
There was a problem hiding this comment.
Let's not forget to delete the example method soon lol
evan-masseau
commented
Dec 21, 2023
| @@ -0,0 +1,29 @@ | |||
| import { NativeModules, Platform } from 'react-native'; | |||
There was a problem hiding this comment.
Extracted this to its own file so that I could import it from index and from constants
evan-masseau
commented
Dec 21, 2023
| @@ -25,11 +41,19 @@ class KlaviyoReactNativeSdkModule internal constructor(private val context: Reac | |||
|
|
|||
| @ReactMethod | |||
| override fun createEvent(event: ReadableMap) { | |||
| println(event) | |||
| val parsedEvent = event.toHashMap() | |||
There was a problem hiding this comment.
Just adjusted this so the app functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started breaking more things out into files
Created a constants file, figure we can also create events.ts, profile.ts etc to store our separate types.