Skip to content

Commit

Permalink
ci: Change branch for start job
Browse files Browse the repository at this point in the history
  • Loading branch information
klerick committed Mar 3, 2024
1 parent 07a58d7 commit 87a949b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"error",
{
"enforceBuildableLibDependency": true,
"allow": [],
"allow": ["json-shared-type", "shared-utils"],
"depConstraints": [
{
"sourceTag": "*",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
# This line is needed for nx affected to work when CI is running on a PR
- run: git branch --track main origin/master
- name: Test and build
run: npx nx affected -t lint test build --parallel=3 --exclude='json-api-front,json-api-server,json-api-server-e2e,shared-utils,json-shared-type,database'
run: npx nx affected -t test build --parallel=3 --exclude='json-api-front,json-api-server,json-api-server-e2e,json-shared-type,database,@nestjs-json-api/source'
- name: Cache npm dependencies
id: cache-dependencies-save
uses: actions/cache/save@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function bindController(
if (!allowMethod.includes(name)) continue;
}

if (!controller.prototype.hasOwnProperty(name)) {
if (!Object.prototype.hasOwnProperty.call(controller, name)) {
// need uniq descriptor for correct work swagger
Reflect.defineProperty(controller.prototype, name, {
value: function (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ export function createController(
const entityName =
entity instanceof Function ? entity.name : entity.options.name;

if (!JsonBaseController.isPrototypeOf(controllerClass)) {
if (
!Object.prototype.isPrototypeOf.call(JsonBaseController, controllerClass)
) {
throw new Error(
`Controller "${controller?.name}" should be inherited of "JsonBaseController"`
);
Expand Down

0 comments on commit 87a949b

Please sign in to comment.