Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-devtools): shift-gql-request-to-server-side #1690

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented Sep 13, 2024

  • experimenting using server actions to hide api keys

PR-Codex overview

This PR updates GraphQL fetching logic, adds new enums, components for manual ruling, and changes subgraph URLs.

Detailed summary

  • Updated GraphQL fetching logic to use gqlRequest function.
  • Added RULING_MODE enum with Manual, AutomaticPreset, and RandomPreset.
  • Added components for manual ruling: ChangeDeveloper, ManualRuling.
  • Changed subgraph URLs in .env.local.example.
  • Refactored components and imports in several files.

The following files were skipped due to too many changes: web-devtools/src/app/(main)/ruler/RulingModes.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Introduced a new gqlRequest function for making GraphQL requests, allowing for flexible queries based on parameters.
  • Improvements

    • Updated environment variable handling for GraphQL URLs by removing the NEXT_PUBLIC_ prefix, enhancing configuration strategies.
    • Simplified GraphQL request process by integrating URL resolution within the new gqlRequest function.
  • Bug Fixes

    • Adjusted GraphQL request handling to streamline data fetching and improve efficiency.

Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The pull request introduces several changes, including a modification of the import path for the getGraphqlUrl function, updates to environment variable access in the getGraphqlUrl file, the introduction of a new gqlRequest function in gqlFetcher.ts, and alterations in the request handling within GraphqlBatcher.tsx. Additionally, the .env.local.example file reflects the renaming of environment variables to remove the NEXT_PUBLIC_ prefix. These changes reflect a reorganization of code structure and a shift in how GraphQL requests are made and managed, without altering the core functionalities of the existing methods.

Changes

Files Change Summary
web-devtools/codegen.ts Updated import path for getGraphqlUrl from ./src/utils/getGraphqlUrl to ./src/actions/getGraphqlUrl.
web-devtools/src/actions/getGraphqlUrl.ts Modified environment variable access from NEXT_PUBLIC_* to * for subgraph URLs in getGraphqlUrl.
web-devtools/src/actions/gqlFetcher.ts Added gqlRequest function to facilitate GraphQL requests with dynamic parameters.
web-devtools/src/context/GraphqlBatcher.tsx Changed the request handling logic to use gqlRequest instead of request, simplifying the GraphQL query process.
web-devtools/.env.local.example Renamed environment variables by removing the NEXT_PUBLIC_ prefix for CORE_SUBGRAPH and DRT_ARBSEPOLIA_SUBGRAPH.

Poem

🐇 In the code where bunnies play,
Paths have shifted, bright as day.
GraphQL hops with newfound grace,
Fetching data at a faster pace.
With each change, we cheer and sing,
For better code, the rabbits bring! 🐇

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2a78ac and 87f492b.

Files selected for processing (1)
  • web-devtools/.env.local.example (1 hunks)
Files skipped from review due to trivial changes (1)
  • web-devtools/.env.local.example

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Sep 13, 2024
@Harman-singh-waraich Harman-singh-waraich changed the base branch from refactor/revamp-devtools-ruler-ui to feat/devtools September 13, 2024 11:31
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for kleros-v2-testnet-devtools ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/66e820bdb9628c2c8dcceed6
😎 Deploy Preview https://deploy-preview-1690--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@Harman-singh-waraich Harman-singh-waraich marked this pull request as draft September 13, 2024 16:29
Base automatically changed from feat/devtools to dev October 14, 2024 14:53
@jaybuidl jaybuidl dismissed coderabbitai[bot]’s stale review October 14, 2024 14:53

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants