Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian Localization Update ru.json #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdqst
Copy link

@mdqst mdqst commented Nov 28, 2024

Description:
This update introduces a complete Russian translation for the header and footer sections of the project. The new localization ensures that Russian-speaking users can navigate and engage with the platform more seamlessly.

Why this matters:

Localization is crucial for reaching a broader audience and improving accessibility. By providing Russian translations, we open the platform to millions of native speakers, fostering inclusivity and engagement.

Key Changes:

  • Translated header elements such as "dapps," "integrations," "research," etc.
  • Fully localized footer items, including important terms like "White Paper," "PNK Token," and "Governance."
  • Translated subscription fields and buttons to enhance user interaction.

This addition improves the user experience for Russian speakers while aligning with the project's global outreach goals. Let me know if there are any additional adjustments needed!

Summary by CodeRabbit

  • New Features
    • Comprehensive updates to the Russian localization, enhancing the user experience for Russian-speaking users.
    • Added new translations for various platform features, including "About," "Cooperative," and "Research."
    • Improved clarity and consistency in the language used throughout the platform.

Copy link

netlify bot commented Nov 28, 2024

👷 Deploy request for kleros-website pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8d74712

Copy link
Contributor

coderabbitai bot commented Nov 28, 2024

Walkthrough

The changes involve a comprehensive update to the Russian localization file ru.json. The translation for "research" has been changed from singular to plural, and the footer section has been entirely reworked with new Russian translations for various terms. This includes the addition of multiple new keys and their corresponding Russian translations, ensuring that all platform features are now accurately represented in Russian. The overall structure of the JSON file remains unchanged.

Changes

File Change Summary
src/intl/ru.json - Updated "research" from "исследование" to "исследования".
- Added multiple keys with their Russian translations, including "about", "cooperative", "blog", etc.

Poem

🐰 In the land of words anew,
Our Russian phrases dance and grew.
From "research" to "cooperative" bright,
Each term now shines with pure delight.
Join us in this joyful spree,
For every rabbit, there's a key! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Nov 28, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
src/intl/ru.json (2)

3-7: Consider translating or transliterating "dapps"

While some technical terms can remain in English, consider translating or transliterating "dapps" to Russian for consistency with other translated terms. Common translations include "децентрализованные приложения" or "даппы".


12-13: Consider adding tooltips for paper references

The translations "Белая книга" and "Желтая книга" are literal translations of "White Paper" and "Yellow Paper". While correct, consider adding tooltips or contextual help to clarify their technical nature for Russian users who might be unfamiliar with these terms in the blockchain context.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cc46db1 and 8d74712.

📒 Files selected for processing (1)
  • src/intl/ru.json (1 hunks)
🔇 Additional comments (2)
src/intl/ru.json (2)

10-32: LGTM! Comprehensive and well-structured Russian translations

The footer translations are accurate and maintain a good balance between technical precision and natural Russian language. The capitalization is consistent throughout the footer section, and technical terms are appropriately handled.


Line range hint 1-35: Verify JSON structure and encoding

Let's ensure the file structure is valid and properly encoded.

✅ Verification successful

JSON structure and encoding verified successfully

The file has been verified to have:

  • Valid JSON syntax with proper nesting and commas
  • Correct structure with two main sections: "header" and "footer"
  • Proper formatting of Cyrillic characters (visible in the content)
  • No trailing commas or structural issues
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify JSON structure and UTF-8 encoding

# Check JSON syntax
jq '.' src/intl/ru.json > /dev/null
if [ $? -eq 0 ]; then
    echo "✓ JSON syntax is valid"
else
    echo "✗ JSON syntax error detected"
fi

# Check file encoding
file -i src/intl/ru.json

Length of output: 219


Script:

#!/bin/bash
# Let's try a different approach to verify encoding and content
# Use cat with hexdump to check for UTF-8 byte patterns
echo "=== Checking file contents and encoding ==="
cat src/intl/ru.json | xxd -p | tr -d '\n' | grep -o 'd0\|d1' | wc -l

# Use grep to find any potential JSON syntax issues
echo "=== Checking for common JSON syntax issues ==="
grep -n '[^[:space:]]$' src/intl/ru.json || echo "No lines ending without comma/brace found"

# Additional JSON validation with more verbose output
echo "=== Detailed JSON structure validation ==="
jq -r 'keys[]' src/intl/ru.json

Length of output: 1583

Comment on lines 3 to 7
"dapps": "dapps",
"integrations": "интеграции",
"research": "исследование",
"research": "исследования",
"blog": "блог",
"about": "о нас"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Maintain consistent capitalization between header and footer

There's an inconsistency in capitalization between header and footer sections:

  • Header: "о нас" (lowercase)
  • Footer: "О нас" (title case)

Consider standardizing the capitalization across sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant