feat(check): skip Others format validate (#159)

kleveross · Dec 15, 2020 · 92e4a8d · 92e4a8d
1 parent 3d37e45
commit 92e4a8d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/model/format.go b/pkg/model/format.go
@@ -67,6 +67,8 @@ func (f Format) ValidateDirectory(rootPath string) error {
 		err = f.validateForXGBoost(modelFilePath, fileList)
 	case FormatMLflow:
 		err = f.validateForMLflow(modelFilePath, fileList)
+	case FormatOthers:
+		return nil
 	default:
 		err = errors.New("unrecognized model format, please check the ormbfile.yaml")
 	}

diff --git a/pkg/model/format_test.go b/pkg/model/format_test.go
@@ -86,9 +86,9 @@ var _ = Describe("Format", func() {
 		Expect(err).To(BeNil())
 	})
 
-	It("Should validate fail for corruptted format", func() {
+	It("Should validate Others for corruptted format successfully", func() {
 		others := model.FormatOthers
 		err := others.ValidateDirectory("../../test/Corrupt")
-		Expect(err).Should(HaveOccurred())
+		Expect(err).Should(BeNil())
 	})
 })