[improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache#19134
Motivation
The java client automatically sets a 30s
ackTimeout
when adeadLetterPolicy
is configured. This behavior was added before there was any ability tonegativeAcknowledge
. Now thatnegativeAcknowledge
exists, it is unnecessary. Furthermore, it is confusing and inconsistent - more details in the issue.Modifications
Removed setting
ackTimeoutMillis
in javaConsumerBuilder
when adeadLetterPolicy
is set.Verifying this change
This change is already covered by existing tests, such as ConsumerBuilderImplTest.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: