Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klevy-toast
Copy link
Owner

@klevy-toast klevy-toast commented Feb 10, 2023

Fixes apache#19134

Motivation

The java client automatically sets a 30s ackTimeout when a deadLetterPolicy is configured. This behavior was added before there was any ability to negativeAcknowledge. Now that negativeAcknowledge exists, it is unnecessary. Furthermore, it is confusing and inconsistent - more details in the issue.

Modifications

Removed setting ackTimeoutMillis in java ConsumerBuilder when a deadLetterPolicy is set.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as ConsumerBuilderImplTest.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@klevy-toast klevy-toast changed the title Remove default 30s ackTimeout when setting DLQ policy on java consumer [improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default 30s ackTimeout when using deadLetterPolicy
1 participant