Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compare code to produce a single NetCDF file with all uncertainties #45

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jlmaurer
Copy link
Contributor

@jlmaurer jlmaurer commented Nov 22, 2024

  • Added code to produce a single netcdf file with uncertainties when calculating comparisons. This also ensures that all the strain rate components and their uncertainties are preserved in the comparison file.
  • Added explicit bounds to figures so that can be changed easier
  • Ensured that all methods return at least a placeholder for velocity uncertainties
  • Removed the check_coregistered_shapes function because wavelets for some reason does not always return the
  • same grid that was passed to it. It turns out not to matter whether the grids are the same as it gets handled by xarray.

@jlmaurer
Copy link
Contributor Author

@kmaterna check this out and let me know if you want any modifications!

from xarray import Dataset

<<<<<<< HEAD
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part from a merge conflict that happened?

@kmaterna
Copy link
Owner

kmaterna commented Dec 6, 2024

Hi @jlmaurer - it looks so good! I think that parameterizing the scales of the outputs was long overdue. I also like removing the check_sizes for an xarray function - how it's supposed to be! I did notice around the top of output_manager.py, there's something that looks like git-generated code, probably from a merge of two versions of the same file. Is that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants