Converted to PSR-2 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix javascript errors starting the job
Make sure that process yields to queuedjobs after each page
API Add description for response code to report
Fixing CurlLinkChecker::checkLink() using incorrect visibility
Fixing CSV export columns to match the ones show in broken links report
Fixing static visibility and moving method to underneath statics
Removing unused static funcs and moving existing statics to top of class
admin/externallinks/start is called, but asynchronously, so the poll() call is never called immediately on start, you have to refresh the page to get it to show.
BUG Indicator stuck on 0% until you refresh the page.
PHPUnit had a Functions.php with global methods like any() for a while (3.7 at least), which clashes with similar globals from Hamcrest (used in Phockito). Both PHPUnit and Phockito use 'classmap' composer autoloading, but that's not directly requiring/evaluating the files. The problem is caused by SilverStripe's ClassLoader which does require ALL subclasses of SapphireTest. This in turn causes PHP outside of the class context to execute, which includes Hamcrest. Changing the include_hamcrest() is not strictly necessary here, but makes the code a bit more resilient against any preceding test including Functions.php from PHPUnit. See hafriedlander/phockito#32 for context.
…hamcrest-globals Include Hamcrest without clashing with PHPUnit globals
Move to new travis containerised infrastructure
Include tests for 3.2 and php 5.6
PL translation added
…e-of-conduct Added standard code of conduct
…torconfig-file Added standard .editorconfig file
helpfulrobot
force-pushed
the
convert-to-psr-2
branch
6 times, most recently
from
4d08953 to
1cef1d1
Compare
helpfulrobot
force-pushed
the
convert-to-psr-2
branch
2 times, most recently
from
ed86811 to
7afffaf
Compare
helpfulrobot
force-pushed
the
convert-to-psr-2
branch
from
7afffaf to
1d00da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm helpful robot. I noticed there were some deviations from PSR-2 in your code. The core committer team recently decided to transition SilverStripe Framework and CMS to PSR-2, and the supported module standard recommends following PSR-2. I've gone ahead and converted files in
codeandteststo PSR-2. If this sounds like something you'd like to merge then go right ahead! Feel free to ask questions or make suggestions for how I can help you more. I've been programmed with a wide range of responses.Have a nice day! [gzzzzrrrkt]