Refactor EPUB2HTML #1693
Open
Refactor EPUB2HTML #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
テスト用にサンプルEPUBファイルを同梱するとかはありですかねえ…(gemに入らずにgitリポジトリ内だけならOK?) |
|
ありがとうございます。gemにはすでにあまり気にせずサンプルとか入れてますし、EPUB zip入れてもさして問題ないような…(逆にgemからサンプルとかテストとかを除くべきか、ということになりそう) EPUB2HTMLについてはVivliostyle CLIもVersaType ConverterもコマンドでEPUBを直接取り込めるようになったのであまり活躍シーンがなくなってきていたのですが、老舗のAntennaHouse Formatterを最近またさわり始めていてこれがまだEPUBを読めないので再び日の目が出て参りました。 |
It assumes that all HTML files are in the same directory and that there are no duplicate filenames.
takahashim
force-pushed
the
refactor-epub2html
branch
from
d52da45 to
4d92c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPUBを経由しないで一発でHTML吐けないかな…と思いながらリファクタリングしてみました。
@htmls、@head、@tailの各インスタンス変数は、スコープを狭くしても混乱しなさそうだったのでローカル変数にしましたFile.basename()同士で比較するようにしましたEPUB2HTML.new.execute_with_params(...)で、CLIからじゃなくても使えるようにしました