Added ip2asn service #83
Closed
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @ShervilG. Unfortunately, making an outbound API request on every DNS query isn't ideal. Trivial to DoS the service. This is why the weather API is cached for a whole region. ip2asn should ideally have a data source that's cached and periodically updated. |
Oh I see, yeah makes sense. We can probably cache the ASNumber to Name data -> https://www.cidr-report.org/as2.0/autnums.html but not sure how to get the data for IP addresses -> ASN mapping 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added an ip2asn service that uses this package for fetching asn info (which uses Team Cymru's IP to ASN mapping service).
Based on the discussion on the issue.
Demo