Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Serving conformance tests and more #88

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Run Serving conformance tests and more #88

merged 3 commits into from
Dec 16, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 11, 2024 •
edited
Loading

Changes

  • As per title. Adds conformance tests for cpu metric that is easier to test.
  • Adds a patch for Serving test helper files. It sets proper resources in created services containers because KEDA's scaledObject requires cpu requests set when the metric used is cpu.
  • Adds a dockerfile for the autoscaler image, for more see the comment here.
  • Fixes the cpu example.

Fixes #

Release Note

Run Serving conformance tests.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.90%. Comparing base (f15726c) to head (89bdef8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   72.90%   72.90%           
=======================================
  Files           8        8           
  Lines         657      657           
=======================================
  Hits          479      479           
  Misses        146      146           
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto skonto requested review from ReToCode and dsimansk December 12, 2024 11:41
@skonto skonto changed the title [wip] Add conformance tests Add conformance tests and more Dec 12, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@skonto skonto changed the title Add conformance tests and more Run Serving conformance tests and more Dec 12, 2024
@skonto
Copy link
Contributor Author

skonto commented Dec 12, 2024

@muscionig fyi

@skonto
Copy link
Contributor Author

skonto commented Dec 12, 2024 •
edited
Loading 

PASS test/conformance/api/v1.TestServiceAccountValidation (0.45s)
PASS test/conformance/api/v1.TestContainerErrorMsg (1.94s)
PASS test/conformance/api/v1.TestRouteAndConfigGenerateName (18.85s)
PASS test/conformance/api/v1.TestRouteGetAndList (19.05s)
PASS test/conformance/api/v1.TestRevisionGetAndList (19.14s)
PASS test/conformance/api/v1.TestServiceCreateListAndDelete (20.32s)
PASS test/conformance/api/v1.TestConfigurationGetAndList (21.94s)
PASS test/conformance/api/v1.TestContainerExitingMsg (22.72s)
PASS test/conformance/api/v1.TestProjectedServiceAccountToken (23.33s)
PASS test/conformance/api/v1.TestProjectedSecretVolume (24.29s)
PASS test/conformance/api/v1.TestProjectedConfigMapVolume (26.40s)
PASS test/conformance/api/v1.TestProjectedComplex (27.63s)
PASS test/conformance/api/v1.TestUpdateConfigurationMetadata (26.82s)
PASS test/conformance/runtime.TestShouldHaveHeadersSet (29.06s)
PASS test/conformance/runtime.TestShouldHaveFiles (29.08s)
PASS test/conformance/runtime.TestMustEnvVars (30.33s)
PASS test/conformance/api/v1.TestServiceCreateWithEmptyDir (30.09s)
PASS test/conformance/runtime.TestMustRunAsUser (31.11s)
PASS test/conformance/runtime.TestShouldHaveStdinEOF (31.15s)
PASS test/conformance/runtime.TestShouldHaveCgroupReadOnly (33.15s)
PASS test/conformance/runtime.TestCmdArgs (34.89s)
PASS test/conformance/runtime.TestMustHaveFiles (34.90s)
PASS test/conformance/runtime.TestWorkingDirService (36.36s)
PASS test/conformance/runtime.TestShouldRunAsUserContainerDefault (36.37s)
PASS test/conformance/runtime.TestMustHaveHeadersSet (36.45s)
PASS test/conformance/runtime.TestMustNotContainerConstraints/TestMountPropagation (0.13s)
PASS test/conformance/runtime.TestMustNotContainerConstraints/TestArbitraryPortName (0.13s)
PASS test/conformance/runtime.TestMustNotContainerConstraints (0.23s)
PASS test/conformance/runtime.TestShouldEnvVars (38.19s)
PASS test/conformance/runtime.TestShouldHaveSysctlReadOnly (38.25s)
PASS test/conformance/runtime.TestMustHaveCgroupConfigured (39.97s)
PASS test/conformance/api/v1.TestConfigMapVolume (41.68s)
PASS test/conformance/api/v1.TestRouteCreation (41.99s)
PASS test/conformance/api/v1.TestSecretVolume (23.98s)
PASS test/conformance/runtime.TestLivenessWithFail (42.93s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestPoststartHook (0.11s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestInvalidUID (0.10s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestTTY (0.11s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestStdinOnce (0.13s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestStdin (0.16s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestPrestopHook (0.64s)
PASS test/conformance/api/v1.TestServiceBYOName (25.39s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestMultiplePorts (0.39s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints/TestHostPort (0.24s)
PASS test/conformance/runtime.TestShouldNotContainerConstraints (0.01s)
PASS test/conformance/api/v1.TestServiceCreateWithMultipleContainers (25.98s)
PASS test/conformance/api/v1.TestSingleConcurrency (45.78s)
PASS test/conformance/runtime.TestProbeRuntimeAfterStartup/periodSeconds=1 (46.00s)
PASS test/conformance/api/v1.TestServiceGenerateName (25.81s)
PASS test/conformance/api/v1.TestCustomResourcesLimits (26.23s)
PASS test/conformance/runtime.TestProtocols/http1 (23.80s)
PASS test/conformance/api/v1.TestRevisionTimeout/does_not_exceed_timeout_seconds (24.85s)
PASS test/conformance/runtime.TestProtocols/h2c (23.68s)
PASS test/conformance/runtime.TestSecretsViaEnv/envFrom (23.67s)
PASS test/conformance/runtime.TestProtocols/default (24.73s)
PASS test/conformance/runtime.TestProtocols (0.00s)
PASS test/conformance/runtime.TestConfigsViaEnv/envFrom (21.72s)
PASS test/conformance/runtime.TestSecretsViaEnv/env (23.81s)
PASS test/conformance/runtime.TestSecretsViaEnv (0.22s)
PASS test/conformance/runtime.TestConfigsViaEnv/env (22.84s)
PASS test/conformance/runtime.TestConfigsViaEnv (0.23s)
PASS test/conformance/runtime.TestProbeRuntime/httpGet (23.65s)
PASS test/conformance/runtime.TestProbeRuntime/exec-period=1 (23.66s)
PASS test/conformance/runtime.TestProbeRuntime/exec (23.67s)
PASS test/conformance/runtime.TestProbeRuntime/tcpSocket-period=1 (22.66s)
PASS test/conformance/runtime.TestProbeRuntime/httpGet-period=1 (22.64s)
PASS test/conformance/api/v1.TestRevisionTimeout/exceeds_timeout_seconds (34.82s)
PASS test/conformance/runtime.TestProbeRuntime/tcpSocket (22.65s)
PASS test/conformance/api/v1.TestRevisionTimeout/writes_first_byte_before_timeout (38.82s)
PASS test/conformance/api/v1.TestRevisionTimeout (0.20s)
PASS test/conformance/api/v1.TestBlueGreenRoute (48.04s)
PASS test/conformance/api/v1.TestServiceWithTrafficSplit (81.57s)
PASS test/conformance/api/v1.TestAnnotationPropagation (64.84s)
PASS test/conformance/runtime.TestProbeRuntime (0.23s)
PASS test/conformance/runtime.TestProbeRuntimeAfterStartup/periodSeconds=0 (58.67s)
PASS test/conformance/runtime.TestProbeRuntimeAfterStartup (0.00s)
PASS test/conformance/runtime
PASS test/conformance/api/v1beta1.TestDomainMapping (99.48s)
PASS test/conformance/api/v1beta1
PASS test/conformance/api/v1.TestServiceCreateAndUpdate (80.26s)
PASS test/conformance/api/v1

DONE 78 tests in 108.024s

ReToCode
ReToCode approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 90f4955 into knative-extensions:main Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @ReToCode