Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip TestBrokerWithConfig #3593

Conversation

maschmid
Copy link
Contributor

skips TestBrokerWithConfig because of #3592

Proposed Changes

  • 🧹 skip TestBrokerWithConfig to not rely on the obsolete Strimzi "Bidirectional Topic Operator"

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bf5622) 63.03% compared to head (4469867) 63.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3593      +/-   ##
============================================
+ Coverage     63.03%   63.05%   +0.01%     
- Complexity      838      840       +2     
============================================
  Files           182      182              
  Lines         12452    12452              
  Branches        268      268              
============================================
+ Hits           7849     7851       +2     
+ Misses         4001     4000       -1     
+ Partials        602      601       -1     
Flag Coverage Δ
java-unittests 76.67% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
Copy link

knative-prow bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@pierDipi
Copy link
Member

/test reconciler-tests

@knative-prow knative-prow bot merged commit ced5da9 into knative-extensions:main Jan 11, 2024
37 checks passed
@maschmid maschmid deleted the maschmid-skip-broker_config_test branch January 11, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants