Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added delivery format to the contract #3980

Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 9, 2024

Part of #3970

Proposed Changes

  • Add the delivery format option to the data plane contract

Copy link

knative-prow bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@knative-prow knative-prow bot requested review from aliok and Leo6Leo July 9, 2024 20:34
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

/cc @Leo6Leo @matzew

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.16%. Comparing base (566cb7c) to head (ffe31e5).
Report is 3 commits behind head on main.

Files Patch % Lines
control-plane/pkg/contract/contract.pb.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3980      +/-   ##
==========================================
- Coverage   48.18%   48.16%   -0.02%     
==========================================
  Files         246      246              
  Lines       14518    14522       +4     
==========================================
  Hits         6995     6995              
- Misses       6817     6821       +4     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Jul 11, 2024

/lgtm
As the number 8 is unique and not being reused in EgressConfig

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit 5b58b47 into knative-extensions:main Jul 12, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants