Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct clusterrole permissions for post install job #4016

Conversation

Cali0707
Copy link
Member

Fixes #4000

Proposed Changes

  • Add the missing rbac verb for the post install to work properly

@Cali0707
Copy link
Member Author

/cc @pierDipi

@knative-prow knative-prow bot added area/control-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2024
@knative-prow knative-prow bot requested review from Leo6Leo, pierDipi and matzew July 29, 2024 14:47
@Cali0707
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cali0707
Copy link
Member Author

/cherry-pick release-1.15

@pierDipi
Copy link
Member

Test in #4015

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link

knative-prow bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.25%. Comparing base (961961c) to head (5956a9f).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.15    #4016   +/-   ##
=============================================
  Coverage         48.25%   48.25%           
=============================================
  Files               246      246           
  Lines             14540    14540           
=============================================
  Hits               7016     7016           
  Misses             6817     6817           
  Partials            707      707           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member


    channelv2_downgrade.go:51: failed to downgrade from channelv2 failed to get deployment: client rate limiter Wait returned an error: context deadline exceeded

/retest

@Cali0707 Cali0707 changed the base branch from main to release-1.15 July 29, 2024 19:42
@Cali0707
Copy link
Member Author

/retest-required

@Cali0707
Copy link
Member Author

@pierDipi I switched the base branch to 1.15, since I realized the downgrade tests will no longer work for 1.14 -> 1.15 (as there are no deployments to remove anymore)

@Cali0707
Copy link
Member Author

/retest-required

Copy link

knative-prow bot commented Jul 30, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main 5956a9f link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit 150dddd into knative-extensions:release-1.15 Jul 30, 2024
45 of 46 checks passed
@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #4022

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@Cali0707: base branch (release-1.15) needs to differ from target branch (release-1.15)

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Cali0707 added a commit to Cali0707/eventing-kafka-broker that referenced this pull request Jul 31, 2024
Cali0707 added a commit to Cali0707/eventing-kafka-broker that referenced this pull request Aug 19, 2024
pierDipi pushed a commit to Cali0707/eventing-kafka-broker that referenced this pull request Sep 16, 2024
pierDipi added a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Sep 16, 2024
…ons#4016) (#1158)

* fix: correct clusterrole permissions (knative-extensions#4016)

Signed-off-by: Calum Murray <[email protected]>

* Run make generate-release

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.14.7 kafka-controller-post-install job errors due to incorrect RBAC rules
3 participants