Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create eventtypes on reply events to triggers and subscriptions #4077

Merged
merged 13 commits into from
Aug 26, 2024

fix: reference is correctly provisioned for dispatchers in control pl…

7192915
Select commit
Loading
Failed to load commit list.
Merged

Create eventtypes on reply events to triggers and subscriptions #4077

fix: reference is correctly provisioned for dispatchers in control pl…
7192915
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2024 in 1s

48.42% (-0.07%) compared to ba49d0f

View this Pull Request on Codecov

48.42% (-0.07%) compared to ba49d0f

Details

Codecov Report

Attention: Patch coverage is 41.89189% with 43 lines in your changes missing coverage. Please review.

Project coverage is 48.42%. Comparing base (ba49d0f) to head (7192915).
Report is 1 commits behind head on main.

Files Patch % Lines
control-plane/pkg/contract/contract.pb.go 17.39% 37 Missing and 1 partial ⚠️
control-plane/pkg/reconciler/channel/channel.go 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4077      +/-   ##
==========================================
- Coverage   48.49%   48.42%   -0.07%     
==========================================
  Files         244      244              
  Lines       14712    14764      +52     
==========================================
+ Hits         7135     7150      +15     
- Misses       6866     6901      +35     
- Partials      711      713       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.