Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update eventing-kafka-broker-eventing nightly #4167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Nov 20, 2024

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing bc6e878...7176ce6:
  > 7176ce6 Add IntegrationSink CRD  (# 8304)
  > 5ad7dab feat: add RequestReply types and CRD (# 8337)
  > 7f313d7 fix: rename `job-sink` to `job_sink` (# 8335)
  > 4f6535a chore: correct comments (# 8336)
  > ebe99e6 Introducing common integration helper and change package name (# 8327)
  > 201e096 [main] Format Go code (# 8334)
  > 6f5edf5 [main] Upgrade to latest dependencies (# 8328)
  > f21370a Integration Api moved to versioned common (# 8325)
  > 63d4da5 Update Integration API and use custom tags on structs for better readability (# 8321)
  > 7abb04d JobSink: Delete secrets associated with jobs when jobs are deleted (# 8331)
  > 8fed0be Allow configuring (opt-in) IMC async handler  (# 8311)

Copy link

knative-prow bot commented Nov 20, 2024

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-extensions/eventing-wg-leads.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
 curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing bc6e878...63d4da5:
 > 63d4da5 Update Integration API and use custom tags on structs for better readability (# 8321)
 > 7abb04d JobSink: Delete secrets associated with jobs when jobs are deleted (# 8331)
 > 8fed0be Allow configuring (opt-in) IMC async handler  (# 8311)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (177b61a) to head (081e89a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4167   +/-   ##
=======================================
  Coverage   45.51%   45.51%           
=======================================
  Files         270      270           
  Lines       19925    19925           
=======================================
  Hits         9069     9069           
  Misses      10129    10129           
  Partials      727      727           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-automation knative-automation force-pushed the update-nightly/eventing branch 2 times, most recently from 6a26746 to 573239f Compare November 22, 2024 11:06
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2024
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2024
@creydr
Copy link
Contributor

creydr commented Nov 26, 2024

/retest

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

knative-prow bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2024
Copy link

knative-prow bot commented Nov 28, 2024

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
bumping knative.dev/eventing bc6e878...7176ce6:
  > 7176ce6 Add IntegrationSink CRD  (# 8304)
  > 5ad7dab feat: add RequestReply types and CRD (# 8337)
  > 7f313d7 fix: rename `job-sink` to `job_sink` (# 8335)
  > 4f6535a chore: correct comments (# 8336)
  > ebe99e6 Introducing common integration helper and change package name (# 8327)
  > 201e096 [main] Format Go code (# 8334)
  > 6f5edf5 [main] Upgrade to latest dependencies (# 8328)
  > f21370a Integration Api moved to versioned common (# 8325)
  > 63d4da5 Update Integration API and use custom tags on structs for better readability (# 8321)
  > 7abb04d JobSink: Delete secrets associated with jobs when jobs are deleted (# 8331)
  > 8fed0be Allow configuring (opt-in) IMC async handler  (# 8311)

Signed-off-by: Knative Automation <[email protected]>
Copy link

knative-prow bot commented Dec 3, 2024

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-keda_eventing-kafka-broker_main 081e89a link true /test reconciler-tests-keda
reconciler-tests_eventing-kafka-broker_main 081e89a link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants