Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite flaky broker_deleted_recreated #4175

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maschmid
Copy link
Contributor

Fixes a flaky BrokerDeletedRecreated test,

the current implementation is not guaranteed to succeed, as it is not defined when the dataplane will reconfigure itself once the old trigger is deleted, so it may sometimes occur, that the new event is still sent to the fist sink, and not the new one.

This new implementation checks that eventually, a sequence is only being received by the other sink.

This approach requires new kinds of assertions about a sequence, instead of just individual events received/not received, hence there is a proposal for some kind of a DSL for assertions over such sequences...

I am not quite sure this kind of DSL is a good idea or if it would be useful in other scenarios, so I could also just rewrite this with just a single one-purpose function instead, if we think there's not much value in it...

Proposed Changes

  • 🧹 Fix a flaky BrokerDeletedRecreated

Copy link

knative-prow bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (6235e66) to head (70f852e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4175   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files         270      270           
  Lines       19925    19925           
=======================================
  Hits         9072     9072           
  Misses      10127    10127           
  Partials      726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maschmid
Copy link
Contributor Author

maschmid commented Dec 4, 2024

/retest-required

Copy link

knative-prow bot commented Dec 4, 2024

@maschmid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main 70f852e link true /test upgrade-tests
reconciler-tests_eventing-kafka-broker_main 70f852e link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant