Fix nil pointer dereference error when parsing config map

[izabelacg]

Changes

• 🐛 Fix nil pointer dereference error when parsing the cors-policy field config-contour config map

PS: Error found while investigating issues in serving tests:

• [Automated] Update net-contour nightly knative/serving#15204
• [WIP] TEST-ONLY change net-contour image to cors changes only knative/serving#15231

/kind bug

Release Note

Resolved a nil pointer exception triggered by the cors-policy field being set to an empty value.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (28e07b4) to head (67ffd7c).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          11       11           
  Lines         708      708           
=======================================
  Hits          665      665           
  Misses         22       22           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

Was there some malformed config in the serving tests?

[izabelacg]

Was there some malformed config in the serving tests?

in the serving e2e script, I set the cors-policy field to empty to disable the feature, which should result in a parsing error. That's why the subsequent tests fail, since the net-contour pod enters in an error state and doesn't recover. I'm waiting on the test PR to confirm if I'm properly removing the field instead of setting it to empty

[dprotaso]

/cherry-pick release-1.14

[knative-prow-robot]

@dprotaso: new pull request created: #1096

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.