Skip to content

Commit

Permalink
bump controller-tools version when updating schema (#838)
Browse files Browse the repository at this point in the history
  • Loading branch information
dprotaso authored Feb 23, 2024
1 parent 9565021 commit 674b31b
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 13 deletions.
59 changes: 47 additions & 12 deletions config/image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,25 @@ spec:
status: {}
schema:
openAPIV3Schema:
description: Image is a Knative abstraction that encapsulates the interface by which Knative components express a desire to have a particular image cached.
description: |-
Image is a Knative abstraction that encapsulates the interface by which Knative
components express a desire to have a particular image cached.
type: object
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
Expand All @@ -59,40 +70,60 @@ spec:
description: Image is the name of the container image url to cache across the cluster.
type: string
imagePullSecrets:
description: ImagePullSecrets contains the names of the Kubernetes Secrets containing login information used by the Pods which will run this container.
description: |-
ImagePullSecrets contains the names of the Kubernetes Secrets containing login
information used by the Pods which will run this container.
type: array
items:
description: LocalObjectReference contains enough information to let you locate the referenced object inside the same namespace.
description: |-
LocalObjectReference contains enough information to let you locate the
referenced object inside the same namespace.
type: object
properties:
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names TODO: Add other useful fields. apiVersion, kind, uid?'
description: |-
Name of the referent.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Add other useful fields. apiVersion, kind, uid?
type: string
x-kubernetes-map-type: atomic
serviceAccountName:
description: 'ServiceAccountName is the name of the Kubernetes ServiceAccount as which the Pods will run this container. This is potentially used to authenticate the image pull if the service account has attached pull secrets. For more information: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account'
description: |-
ServiceAccountName is the name of the Kubernetes ServiceAccount as which the Pods
will run this container. This is potentially used to authenticate the image pull
if the service account has attached pull secrets. For more information:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account
type: string
status:
description: Status communicates the observed state of the Image (from the controller).
type: object
properties:
annotations:
description: Annotations is additional Status fields for the Resource to save some additional State as well as convey more information to the user. This is roughly akin to Annotations on any k8s resource, just the reconciler conveying richer information outwards.
description: |-
Annotations is additional Status fields for the Resource to save some
additional State as well as convey more information to the user. This is
roughly akin to Annotations on any k8s resource, just the reconciler conveying
richer information outwards.
type: object
additionalProperties:
type: string
conditions:
description: Conditions the latest available observations of a resource's current state.
type: array
items:
description: 'Condition defines a readiness condition for a Knative resource. See: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties'
description: |-
Condition defines a readiness condition for a Knative resource.
See: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties
type: object
required:
- status
- type
properties:
lastTransitionTime:
description: LastTransitionTime is the last time the condition transitioned from one status to another. We use VolatileTime in place of metav1.Time to exclude this from creating equality.Semantic differences (all other things held constant).
description: |-
LastTransitionTime is the last time the condition transitioned from one status to another.
We use VolatileTime in place of metav1.Time to exclude this from creating equality.Semantic
differences (all other things held constant).
type: string
message:
description: A human readable message indicating details about the transition.
Expand All @@ -101,7 +132,9 @@ spec:
description: The reason for the condition's last transition.
type: string
severity:
description: Severity with which to treat failures of this type of condition. When this is not specified, it defaults to Error.
description: |-
Severity with which to treat failures of this type of condition.
When this is not specified, it defaults to Error.
type: string
status:
description: Status of the condition, one of True, False, Unknown.
Expand All @@ -110,7 +143,9 @@ spec:
description: Type of condition.
type: string
observedGeneration:
description: ObservedGeneration is the 'Generation' of the Service that was last processed by the controller.
description: |-
ObservedGeneration is the 'Generation' of the Service that
was last processed by the controller.
type: integer
format: int64
additionalPrinterColumns:
Expand Down
2 changes: 1 addition & 1 deletion hack/update-schemas.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set -o pipefail

REPO_ROOT="$(git rev-parse --show-toplevel)"

go run sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.2 \
go run sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0 \
schemapatch:manifests=config/,generateEmbeddedObjectMeta=false \
output:dir=config \
paths=./pkg/apis/...
Expand Down

0 comments on commit 674b31b

Please sign in to comment.