Add target platform flag to build script #1981
Conversation
knative-prow
bot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 234 234
Lines 16482 16482
=======================================
Hits 12148 12148
Misses 3506 3506
Partials 828 828 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
/lgtm |
|
@Kaustubh-pande: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| GOOS="${ARGS[1]}" | ||
| GOARCH="${ARGS[2]}" |
There was a problem hiding this comment.
Are you sure those will always be 1 and 2 args?
There was a problem hiding this comment.
It's being used downstream, os I think we can defer to consuming script to provide all args as expected.
Co-authored-by: Chris Suszynski <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Changes
Reference
Fixes #
Release Note