Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should add our LinkedIn page link to follow us section of our website #5972

Closed
nainaz opened this issue May 15, 2024 · 9 comments · Fixed by #5976
Closed

We should add our LinkedIn page link to follow us section of our website #5972

nainaz opened this issue May 15, 2024 · 9 comments · Fixed by #5976
Assignees

Comments

@nainaz
Copy link
Contributor

nainaz commented May 15, 2024

Describe the change you'd like to see
In the Follow us section we should have the link to our Linkedin page as well
https://www.linkedin.com/company/knative
Additional context
Add any other context or screenshots about the feature request here.

@shivamgupta2020
Copy link
Contributor

/assign

@shivamgupta2020
Copy link
Contributor

@nainaz I created a PR regarding this. Following is the result. Please review it.
image

This was referenced May 15, 2024
@TenzDelek
Copy link

@nainaz @shivamgupta2020 it would be also a plus to add it in the footer as well!!
image

@shivamgupta2020
Copy link
Contributor

@TenzDelek Footer has been there. I only changed what's next section.
image

@TenzDelek
Copy link

What I mean is to add the LinkedIn link in the footer as well. Might be relevant to do so.

@shivamgupta2020
Copy link
Contributor

Updated in recent commit:
image

@shivamgupta2020
Copy link
Contributor

@nainaz can u review the PR and merge it.

@DhairyaMajmudar
Copy link

@aliok @nainaz if it is okay can I continue working on this issue ?
This will be my approch #5976 (comment)

@aliok
Copy link
Member

aliok commented Jun 6, 2024

@DhairyaMajmudar , work is pretty much done in #5976 (comment)

@github-project-automation github-project-automation bot moved this from Ice Box to Done in UX WG Roadmap Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
5 participants