-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Linkedln page link #5976
added Linkedln page link #5976
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please revert the formatting changes that are not relevant to the task?
Also, can you add some spacing between X and LinkedIn logos?
I think it will look much better if we split the logos section into 4 columns. One column for each logo. Also while hovering it shows the logo into greenish gradient which can be made better if we change the color into the actual logo color (egs: black for Twitter logo) or we can also change the logo color into color matching Knative logos while hovering. |
dc34097
to
b8c69a0
Compare
@aliok I have updated the linting of code and add some space between the logo. |
Hi @DhairyaMajmudar , |
If you remove the irrelevant formatting changes, we can merge this PR. Thanks! |
@aliok, I've reverted the formatting changes. Please review it on your machine. |
When I check https://github.com/knative/docs/pull/5976/files I see they are still there. |
@aliok, I've reverted the formatting changes. Please review it. |
Looks good to me. I like the space between X and in. |
Thanks @shivamgupta2020 It looks great. About the previous comments about colors, etc. Let's address them separately as we need to change those everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, shivamgupta2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5972
Proposed Changes