Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-up-a-local-knative-environment-with-kind.md #5670

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

vatro
Copy link
Contributor

@vatro vatro commented Aug 24, 2023

Correcting two port typos.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vatro / name: Vatroslav Vrbanic (55b52f8)

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 55b52f8
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64e7eed76608d4000819b596
😎 Deploy Preview https://deploy-preview-5670--knative.netlify.app/blog/articles/set-up-a-local-knative-environment-with-kind
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 24, 2023

Welcome @vatro! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot requested review from psschwei and skonto August 24, 2023 23:59
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, vatro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@knative-prow knative-prow bot merged commit 1201e36 into knative:main Aug 25, 2023
12 checks passed
@ReToCode
Copy link
Member

Thank you!

@psschwei
Copy link
Contributor

This article was deprecated in #4982 and is no longer available from the main site.

@vatro
Copy link
Contributor Author

vatro commented Aug 25, 2023

I've found it useful as I was searching for info on how to switch kourier service to be of NodePort type instead of LoadBalancer while adding Knative Serving to my "office-lab" Kubernetes cluster (bare-metal).

@vatro vatro deleted the vatro-patch-1 branch August 25, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants