Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DomainMapping to v1beta1 from v1alpha1 #5673

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Update DomainMapping to v1beta1 from v1alpha1 #5673

merged 1 commit into from
Sep 3, 2023

Conversation

xiangpingjiang
Copy link
Contributor

"Fixes #5672 " or "Add description of the problem this PR solves"

Proposed Changes

  • Update DomainMapping to v1beta1 from v1alpha1

@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20f27f8
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64f18ff46bff6f000840e699
😎 Deploy Preview https://deploy-preview-5673--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow
Copy link

knative-prow bot commented Sep 1, 2023

Welcome @xiangpingjiang! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2023
@nak3 nak3 added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 3, 2023
@nak3
Copy link
Contributor

nak3 commented Sep 3, 2023

/lgtm
/approve

Thank you!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2023
@knative-prow knative-prow bot merged commit 6b0b256 into knative:main Sep 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr Awaiting requested review from csantanapr

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@nak3 nak3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DomainMapping to v1beta1 from v1alpha1
2 participants
@xiangpingjiang @nak3