Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix deprecation warning (#5727)" #5730

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Revert "Fix deprecation warning (#5727)" #5730

merged 1 commit into from
Oct 23, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Oct 23, 2023 •
edited
Loading

This reverts commit 7aed08d.

#5727 fixes the warning but brakes the format.

/cc @pmbanugo

@knative-prow knative-prow bot requested a review from pmbanugo October 23, 2023 10:39
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f61ef85
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65364d5972281000086aac4d
😎 Deploy Preview https://deploy-preview-5730--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2023
@nak3
Copy link
Contributor Author

nak3 commented Oct 23, 2023 •
edited
Loading

Updating of mkdocs-material==8.2.7 causes the format issue and I'm not sure how to fix it with my limited knowledge of UI.

Alternative solution is removing emoji extension if we don't use it. But I feel it will cause another issue so we should revert the change for now

ReToCode
ReToCode approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 22c6a55 into knative:main Oct 23, 2023
18 of 19 checks passed
@ReToCode ReToCode mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nak3 @ReToCode