Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to new release version #5738

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

ReToCode
Copy link
Member

Changes

  • Bump to new release version

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 268aa2d
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/653b87684e4fbb00084482dc
😎 Deploy Preview https://deploy-preview-5738--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from nak3 and snneji October 27, 2023 09:48
@knative-prow
Copy link

knative-prow bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2023
@ReToCode
Copy link
Member Author

/override "Knative Verify / Verify mkdocs strict (1.16.x, ubuntu-latest)"

@knative-prow
Copy link

knative-prow bot commented Oct 27, 2023

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Knative Verify / Verify mkdocs strict (1.16.x, ubuntu-latest)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Verify mkdocs strict (1.16.x, ubuntu-latest)
  • netlify/knative/deploy-preview
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Knative Verify / Verify mkdocs strict (1.16.x, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member Author

/override "Verify mkdocs strict (1.16.x, ubuntu-latest)"

@knative-prow
Copy link

knative-prow bot commented Oct 27, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: Verify mkdocs strict (1.16.x, ubuntu-latest)

In response to this:

/override "Verify mkdocs strict (1.16.x, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@knative-prow knative-prow bot merged commit c120f1b into knative:main Oct 27, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants