-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Knative v1.12.0 release blog #5739
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cherry-pick release-1.12 |
@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "Verify mkdocs strict (1.16.x, ubuntu-latest)" |
@ReToCode: Overrode contexts on behalf of ReToCode: Verify mkdocs strict (1.16.x, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If I recall correctly blogs are not versioned. It doesn't need a cherry-pick, but it doesn't break anything either. I did the same during last or last-1 release. :) |
/hold for other reviewers |
Otherwise LGTM 👍 |
/override "Verify mkdocs strict (1.16.x, ubuntu-latest)" |
@ReToCode: Overrode contexts on behalf of ReToCode: Verify mkdocs strict (1.16.x, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As Christoph is on PTO and David was ok with the changes, /unhold |
@ReToCode: new pull request created: #5742 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
PTAL and please double check your names for spelling & copy paste error. Thanks! Feel free to directly change stuff
/cc @knative/technical-oversight-committee
/cc @knative/knative-release-leads