Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made top three sections of home page responsive #6068

Merged
merged 3 commits into from
Sep 17, 2024
Merged

made top three sections of home page responsive #6068

merged 3 commits into from
Sep 17, 2024

Conversation

ShravaniAK
Copy link
Contributor

I have made top three sections of home page responsive.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2024
@knative-prow knative-prow bot requested review from nainaz and ReToCode July 22, 2024 15:18
@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1154a15
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66bcafba5c48bd0008752433
😎 Deploy Preview https://deploy-preview-6068--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShravaniAK
Copy link
Contributor Author

/cc @zainabhusain227 @Cali0707 @aliok

@ShravaniAK ShravaniAK mentioned this pull request Jul 22, 2024
Closed
@ShravaniAK
Copy link
Contributor Author

I have worked on the feedback that was received in the meet,
I have made the following changes:

  1. fixed the line break in the "need to know more section"
  2. fixed the size of the text in the "Why serverless container"
  3. reduced the empty gap between the icons of "Why serverless container" section.

@Cali0707
Copy link
Member

Cali0707 commented Aug 7, 2024

@ShravaniAK thank you! We will try and do a final review of this PR tomorrow in the UX meeting

@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 8, 2024

Review result from UX WG meeting: 2024-08-08 @ShravaniAK

Decision: Change requested

Comments:

  • Explore Knative button is too close to the bottom under mobile view
  • Title of the home page add the padding to the left and right under mobile view

@ShravaniAK
Copy link
Contributor Author

I have made the requested changes , thanks

Cali0707
Cali0707 reviewed Aug 14, 2024
View reviewed changes
overrides/home.html
@@ -36,7 +36,7 @@ <h3 class="trusted-by">Trusted by</h3>
<div class="md-grid md-typeset">
<h1>Need to know more?</h1>
<p class="normal-text">
Learn about how Knative works with Kubernetes and the underlying ideas behind containers<br>
Learn about how Knative works with Kubernetes and the underlying ideas behind containers <br class="br">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn about how Knative works with Kubernetes and the underlying ideas behind containers <br class="br">
Learn about how Knative works with Kubernetes and the underlying ideas behind containers

Instead of setting display: none for this class, can we just remove the tag?

Cali0707
Cali0707 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@knative-prow knative-prow bot merged commit 65c2952 into knative:main Sep 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@nainaz nainaz Awaiting requested review from nainaz

@ReToCode ReToCode Awaiting requested review from ReToCode

@aliok aliok Awaiting requested review from aliok

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShravaniAK @Cali0707 @Leo6Leo