Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image blog post #6106

Merged

Conversation

slinkydeveloper
Copy link
Contributor

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2024
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 24b6e53
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66d815dced54fb0009ef49ae
😎 Deploy Preview https://deploy-preview-6106--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slinkydeveloper
Copy link
Contributor Author

cc @dsimansk @pierDipi just added an image to the blog post from the previous PR :)

@dsimansk
Copy link
Contributor

dsimansk commented Sep 4, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link

knative-prow bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@knative-prow knative-prow bot merged commit bb2cede into knative:main Sep 4, 2024
19 checks passed
@slinkydeveloper slinkydeveloper deleted the add-image-restate-blog-post branch September 4, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants