Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document host* and shareProcessNamespace flags #6123

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Document host* and shareProcessNamespace flags #6123

merged 1 commit into from
Sep 18, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Sep 17, 2024 •
edited
Loading

Fixes #6103

Proposed Changes

  • As per title

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4065af7
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66e9963ab50ce700089c39df
😎 Deploy Preview https://deploy-preview-6123--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

skonto
skonto commented Sep 17, 2024
View reviewed changes
docs/serving/configuration/feature-flags.md

!!! warning

`shareProcessNamespace` and `hostPID` cannot both be set.
Copy link
Contributor Author

@skonto skonto Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://github.com/kubernetes-client/go/blob/master/kubernetes/docs/V1PodSpec.md for this, probably we should catch this a bit earlier at the Serving side, before any resources are created.

@skonto
Copy link
Contributor Author

skonto commented Sep 17, 2024

@ReToCode are there any other flags missing?

ReToCode
ReToCode approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I'm aware of.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5afac9a into knative:main Sep 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document pending Serving pod spec properties.
2 participants
@skonto @ReToCode