added event format to dispatcher

[EraKin575]

added event format in event dispatcher
Fixes #8074

Proposed Changes

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Docs

[knative-prow]

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (1e4183f) to head (f129b65).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8096      +/-   ##
==========================================
+ Coverage   67.87%   67.92%   +0.05%     
==========================================
  Files         368      368              
  Lines       17554    17564      +10     
==========================================
+ Hits        11915    11931      +16     
+ Misses       4894     4887       -7     
- Partials      745      746       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

Nice start @EraKin575 - I left some feedback

[EraKin575]

@Cali0707 thanks for your review. I have a question though. How can I check for binary format in unit tests

[Cali0707]

How can I check for binary format in unit tests

In the http receiver handler function, you will be able to:

1. convert the request to a cloudevent message type
2. Read the encoding from the message with m.ReadEncoding()
3. Compare this with the constants from the cloudevents binding package for the type Encoding
   Hope that helps!

[EraKin575]

How can I check for binary format in unit tests

In the http receiver handler function, you will be able to:

1. convert the request to a cloudevent message type
2. Read the encoding from the message with m.ReadEncoding()
3. Compare this with the constants from the cloudevents binding package for the type Encoding
   Hope that helps!

Thanks! Will try this

[Cali0707]

Hey @EraKin575 any updates here? Anything we can help you with?

[EraKin575]

Hey @EraKin575 any updates here? Anything we can help you with?

got busy with some stuff. I will finish this issue ASAP

[EraKin575]

@Cali0707 , I can't quite get the http receiver part, can you please explain it in a bit more detail?

[Cali0707]

@Cali0707 , I can't quite get the http receiver part, can you please explain it in a bit more detail?

Yeah, in the StartServer code for the tests, you provide a handler function that handles the http request. You can add the logic you need in there

[EraKin575]

@Cali0707 , I can't quite get the http receiver part, can you please explain it in a bit more detail?

Yeah, in the StartServer code for the tests, you provide a handler function that handles the http request. You can add the logic you need in there

thanks @Cali0707 ! I have done another commit. Please review it and advise me for any further changes

[Cali0707]

/ok-to-test

[Cali0707]

Nice work @EraKin575 - just a few changes and then this should be good to merge :)

[Cali0707]

/lgtm

/cc @pierDipi

Could you provide a second review here?

[Cali0707]

/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, EraKin575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment