Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependecy for boson-project git repository on e2e tests #2537

Merged

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🧹 Remove dependecy for boson-project git repository on e2e tests
  • 🧹 Moving test remote repository to oncluster tests due dependency on gitserver

/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2024
@knative-prow knative-prow bot requested review from rhuss and vyasgun October 9, 2024 03:25
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (47ccd6c) to head (0ec33df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   61.45%   66.86%   +5.41%     
==========================================
  Files         130      130              
  Lines       15465    12036    -3429     
==========================================
- Hits         9504     8048    -1456     
+ Misses       5023     3012    -2011     
- Partials      938      976      +38     
Flag Coverage Δ
e2e-test 36.58% <ø> (+0.02%) ⬆️
e2e-test-oncluster 33.86% <ø> (+0.45%) ⬆️
e2e-test-oncluster-runtime 29.69% <ø> (?)
e2e-test-runtime-go 26.59% <ø> (?)
e2e-test-runtime-node 25.98% <ø> (?)
e2e-test-runtime-python 25.98% <ø> (?)
e2e-test-runtime-quarkus 26.08% <ø> (?)
e2e-test-runtime-rust 25.11% <ø> (?)
e2e-test-runtime-springboot 25.13% <ø> (?)
e2e-test-runtime-typescript 26.07% <ø> (?)
integration-tests 53.06% <ø> (+2.31%) ⬆️
unit-tests 51.63% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

knFunc.TestCmd.Exec("create",
"--language", "go",
"--template", "envs",
"--repository", "http://github.com/boson-project/test-templates.git", // TODO Make on config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
Copy link

knative-prow bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 59aa11c into knative:main Oct 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants