-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependecy for boson-project git repository on e2e tests #2537
Remove dependecy for boson-project git repository on e2e tests #2537
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
+ Coverage 61.45% 66.86% +5.41%
==========================================
Files 130 130
Lines 15465 12036 -3429
==========================================
- Hits 9504 8048 -1456
+ Misses 5023 3012 -2011
- Partials 938 976 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
knFunc.TestCmd.Exec("create", | ||
"--language", "go", | ||
"--template", "envs", | ||
"--repository", "http://github.com/boson-project/test-templates.git", // TODO Make on config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup