Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Add more env vars for pingsource adapter env var preservation #1537

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1534

Add more env vars for pingsource adapter env var preservation to prevent the eventing-controller and the operator fighting to set env var values.

@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign kvmware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ed4238) 79.32% compared to head (3d620b7) 79.32%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10    #1537   +/-   ##
=============================================
  Coverage         79.32%   79.32%           
=============================================
  Files                40       40           
  Lines              1775     1775           
=============================================
  Hits               1408     1408           
  Misses              267      267           
  Partials            100      100           
Files Changed Coverage Δ
...knativeeventing/common/replicasenvvarstransform.go 70.58% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliok
Copy link
Member

aliok commented Aug 17, 2023

/close

This fails, so I've created #1539

@knative-prow knative-prow bot closed this Aug 17, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

@aliok: Closed this PR.

In response to this:

/close

This fails, so I've created #1539

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants