Add Istio ambient to KinD test

[nak3]

This patch demonstrates ambient profile knative-extensions/net-istio#1133 on KinD test.

This could be one of solutions for #11906

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (ff6e78d) 86.26% compared to head (4bababc) 86.29%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14103      +/-   ##
==========================================
+ Coverage   86.26%   86.29%   +0.02%     
==========================================
  Files         199      199              
  Lines       14811    14811              
==========================================
+ Hits        12777    12781       +4     
+ Misses       1731     1729       -2     
+ Partials      303      301       -2     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nak3]

/test upgrade-tests

[nak3]

/cc @dprotaso @psschwei @ReToCode

Is it not alright to add the ambient in KinD?

[nak3]

/test upgrade-tests

[skonto]

Hopefully existing shell lint issues will be fixed with #13971.

[skonto]

Looking at the ambient runs here: https://github.com/knative/serving/actions/runs/5408789726/jobs/9828278368?pr=14103, it seems that:

++ local profile=istio-ci-no-mesh
++ ((  KIND  ))
++ ((  AMBIENT  ))
++ profile=istio-kind-no-mesh

[nak3]

Hmm.. I will fix the CI.

2023-06-29T14:08:31.2124949Z 2:08:31PM: ---- waiting on 5 changes [192/197 done] ----
2023-06-29T14:08:58.7199450Z 2:08:58PM: fail: reconcile deployment/webhook (apps/v1) namespace: 5085b851-3fbc-4713-b628-531cf85ec1b1
2023-06-29T14:08:58.7200279Z 2:08:58PM:  ^ Deployment is not progressing: ProgressDeadlineExceeded (message: ReplicaSet "webhook-54554bcbd" has timed out progressing.)
2023-06-29T14:08:58.7508606Z kapp: Error: waiting on reconcile deployment/webhook (apps/v1) namespace: 5085b851-3fbc-4713-b628-531cf85ec1b1:

[dprotaso]

Is it not alright to add the ambient in KinD?

I'm ok adding ambient

[nak3]

Thank you!
Due to a bug istio/istio#45781, we have to deploy ztunnel -> istio-cni-node in this order. I'm looking into the solution for now.

[nak3]

This is ready. May I ask you to review this?

[ReToCode]

It seems we are getting a lot of env variations here (including the encryption stuff). WDYT about having the istio profile as a variable instead of having MESH and AMBIENT?

[nak3]

Do you mean that adding the PROFILE in test/e2e-common.sh like?

    --mesh)
      readonly MESH=1
      readonly PROFILE="istio-ci-mesh"
      return 1
      ;;
    --no-mesh)
      readonly MESH=0
      readonly PROFILE="istio-ci-no-mesh"
      return 1
      ;;

If so, it sounds good to me. If you are okay, I would like to change it in another PR as it may fix #14182 (then need some more debug...).

[ReToCode]

Or even add just one variable to the GH-actions with MESH_PROFILE and then specify the profile directly there? I don't see much reason for the abstraction we have, as we only target MESH in the istio-case anyway.

Works for me to do it in a followup.

[ReToCode]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nak3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment