Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable system internal tls for contour #15374

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 4, 2024

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode July 4, 2024 20:32
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (b0eab7d) to head (de24cab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15374   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         219      219           
  Lines       13584    13584           
=======================================
  Hits        11490    11490           
- Misses       1726     1727    +1     
+ Partials      368      367    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

dprotaso commented Jul 7, 2024

/test contour-latest_serving_main
/test contour-tls_serving_main

@dprotaso
Copy link
Member Author

dprotaso commented Jul 7, 2024

'All cluster resources were brought up, but: only 10 nodes out of 12 have registered;

/retest

@dprotaso
Copy link
Member Author

dprotaso commented Jul 7, 2024

/hold cancel

/assign @ReToCode

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link

knative-prow bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a923915 into knative:main Jul 8, 2024
69 checks passed
@dprotaso dprotaso deleted the contour-system-internal-tls branch July 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants