-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable system internal tls for contour #15374
enable system internal tls for contour #15374
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15374 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 219 219
Lines 13584 13584
=======================================
Hits 11490 11490
- Misses 1726 1727 +1
+ Partials 368 367 -1 ☔ View full report in Codecov by Sentry. |
/test contour-latest_serving_main |
/retest |
/hold cancel /assign @ReToCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Depends on knative-extensions/net-contour#1110
/hold